Create changeset to transfer back mint authority to state pda in solana#22394
Open
agusaldasoro wants to merge 7 commits into
Open
Create changeset to transfer back mint authority to state pda in solana#22394agusaldasoro wants to merge 7 commits into
agusaldasoro wants to merge 7 commits into
Conversation
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
✅ No conflicts with other open PRs targeting |
agusaldasoro
commented
May 12, 2026
agusaldasoro
requested review from
AmrMohamedRezk,
KodeyThomas,
asoliman92,
carte7000,
chris-de-leon-cll,
makramkd,
toblich and
winder
product-security-plaid-production
Bot
requested review from
DimitriosNaikopoulos,
justinkaseman and
kalverra
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH — introduces a new Solana deployment changeset that mutates SPL mint authority (high blast radius if mis-targeted), plus dependency bumps across multiple Go modules.
Changes:
- Adds a new Solana deployment changeset to transfer SPL token mint authority back to the token pool signer PDA for Burn/Mint pools.
- Bumps
chainlink-ccip/chains/solana/gobindingsto a newer pseudo-version across deployment, scripts, and test modules. - Adds a Changesets entry documenting the patch.
Scrupulous human review areas:
TransferMintAuthorityToSignerPDA: verify the instruction targets the intended on-chain program ID (bindings ProgramID vs deployed pool address) and that the account list matches the program’s expectations.useMcmsbranch: confirm the authority selection (deployer vs timelock signer) is correct for the environments this will be run in, and that the timelock proposal parameters are valid.- End-to-end operational flow: confirm this cannot accidentally “brick” mint authority by submitting to the wrong program or with the wrong current authority.
Reviewed changes
Copilot reviewed 8 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
deployment/ccip/changeset/solana_v0_1_1/cs_token_pool.go |
Adds the new changeset and associated config/validation for transferring mint authority to the pool signer PDA. |
deployment/go.mod |
Bumps Solana gobindings dependency version. |
deployment/go.sum |
Updates checksums for the bumped gobindings version. |
core/scripts/go.mod |
Bumps Solana gobindings dependency version (scripts module). |
core/scripts/go.sum |
Updates checksums for the bumped gobindings version (scripts module). |
integration-tests/go.mod |
Bumps Solana gobindings dependency version (integration tests). |
integration-tests/go.sum |
Updates checksums for the bumped gobindings version (integration tests). |
integration-tests/load/go.mod |
Bumps Solana gobindings dependency version (load tests). |
integration-tests/load/go.sum |
Updates checksums for the bumped gobindings version (load tests). |
system-tests/lib/go.mod |
Bumps Solana gobindings dependency version (system test lib). |
system-tests/lib/go.sum |
Updates checksums for the bumped gobindings version (system test lib). |
system-tests/tests/go.mod |
Bumps Solana gobindings dependency version (system tests). |
system-tests/tests/go.sum |
Updates checksums for the bumped gobindings version (system tests). |
.changeset/fierce-foxes-guess.md |
Adds a patch changeset note describing the mint-authority cleanup. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new changeset to clean up Solana token mint authority after migration, including a new deployment changeset for transferring mint authority to the pool signer PDA for burn-and-mint token pools. It also updates the
chainlink-ccip/chains/solana/gobindingsdependency to a newer version across multiple modules.Solana Mint Authority Migration and Clean-up:
TransferMintAuthorityToSignerPDA, which provides logic and configuration for transferring Solana token mint authority to the pool signer PDA, specifically for burn-and-mint pools. This includes validation, instruction building, and support for MCMS timelock proposals. [1] [2]Dependency Updates:
chainlink-ccip/chains/solana/gobindingsto versionv0.0.0-20260511195239-0f6e1b177fc7incore/scripts/go.mod,deployment/go.mod,integration-tests/go.mod,integration-tests/load/go.mod,system-tests/lib/go.mod, andsystem-tests/tests/go.modto ensure compatibility with the new mint authority transfer logic. [1] [2] [3] [4] [5] [6]Changeset Documentation:
.changeset/fierce-foxes-guess.mdto document the new changeset and clarify the purpose of the Solana mint authority clean-up after migration.Deployment Code Enhancements:
burnmint_token_poolbinding for versionv1_6_2to support the new authority transfer logic indeployment/ccip/changeset/solana_v0_1_1/cs_token_pool.go.